]> dgit.raspbian.org Git - gnome-shell.git/commit
messageTray: Avoid notification double destruction after activation
authorSebastian Keller <skeller@gnome.org>
Thu, 5 Mar 2026 12:04:37 +0000 (13:04 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 14 Mar 2026 17:43:25 +0000 (18:43 +0100)
commit03d4105a1fea8479d6e455b57d3aad4ea7d799da
treeb6093545137fdb761d62a596a54b43fab59189b7
parente25ca28dbf8789b4ec82769ed5afc47e69a13089
messageTray: Avoid notification double destruction after activation

The activation handler of a notification may indirectly have already
destroyed it before `activate()` continues and tries to destroy it.

This happened for example in the `FdoNotificationDaemon` activation
handler when no default actions are specified, which ends up calling
`destroyNonResidentNotifications()`.

Another case where this could happen is the `WindowAttentionHandler`
which activates the window and upon activation of the window destroys
the entire notification source, which also destroys the notification.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5421
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4113>
(cherry picked from commit 2fe0c2b4b23e526801ade3d54dedb578af04307c)
js/ui/messageTray.js